.travis.yml

@@ -1,8 +1,9 @@
 language: node_js
 
 node_js:
+  - 12
   - 10
-  - 8
+  - 8.3
 
 # Trigger a push build on master and greenkeeper branches + PRs build on every branches
 # Avoid double build on PRs (See https://github.com/travis-ci/travis-ci/issues/1147)

lib/publish.js

@@ -50,7 +50,7 @@ module.exports = async (pluginConfig, context) => {
   const draftRelease = {...releaseData, draft: true};
 
   const {
-    data: {html_url: url, upload_url: uploadUrl, id: releaseId},
+    data: {upload_url: uploadUrl, id: releaseId},
   } = await github.repos.createRelease(draftRelease);
 
   // Append assets to the release
@@ -108,7 +108,9 @@ module.exports = async (pluginConfig, context) => {
   };
   /* eslint-enable */
 
-  await github.repos.updateRelease(release);
+  const {
+    data: {html_url: url},
+  } = await github.repos.updateRelease(release);
 
   logger.log('Published GitHub release: %s', url);
   return {url, name: 'GitHub release'};

package.json

@@ -11,11 +11,6 @@
   "bugs": {
     "url": "https://github.com/semantic-release/github/issues"
   },
-  "config": {
-    "commitizen": {
-      "path": "cz-conventional-changelog"
-    }
-  },
   "contributors": [
     "Stephan Bönnemann <stephan@boennemann.me> (http://boennemann.me)",
     "Gregor Martynus (https://twitter.com/gr2m)"
@@ -43,9 +38,7 @@
     "ava": "^2.0.0",
     "clear-module": "^4.0.0",
     "codecov": "^3.5.0",
-    "commitizen": "^3.0.0",
-    "cz-conventional-changelog": "^2.0.0",
-    "nock": "^10.0.0",
+    "nock": "^11.1.0",
     "nyc": "^14.1.1",
     "proxy": "^0.2.4",
     "proxyquire": "^2.0.0",
@@ -104,7 +97,6 @@
     "url": "https://github.com/semantic-release/github.git"
   },
   "scripts": {
-    "cm": "git-cz",
     "codecov": "codecov -f coverage/coverage-final.json",
     "lint": "xo",
     "pretest": "npm run lint",

test/publish.test.js

@@ -101,6 +101,7 @@ test.serial('Publish a release with one asset', async t => {
   };
   const nextRelease = {version: '1.0.0', gitHead: '123', gitTag: 'v1.0.0', notes: 'Test release note body'};
   const options = {branch: 'master', repositoryUrl: `https://github.com/${owner}/${repo}.git`};
+  const untaggedReleaseUrl = `https://github.com/${owner}/${repo}/releases/untagged-123`;
   const releaseUrl = `https://github.com/${owner}/${repo}/releases/${nextRelease.version}`;
   const assetUrl = `https://github.com/${owner}/${repo}/releases/download/${nextRelease.version}/.dotfile`;
   const releaseId = 1;
@@ -115,7 +116,7 @@ test.serial('Publish a release with one asset', async t => {
       body: nextRelease.notes,
       draft: true,
     })
-    .reply(200, {upload_url: uploadUrl, html_url: releaseUrl, id: releaseId})
+    .reply(200, {upload_url: uploadUrl, html_url: untaggedReleaseUrl, id: releaseId})
     .patch(`/repos/${owner}/${repo}/releases/${releaseId}`, {
       draft: false,
     })
@@ -146,6 +147,7 @@ test.serial('Publish a release with one asset and custom github url', async t =>
   };
   const nextRelease = {version: '1.0.0', gitHead: '123', gitTag: 'v1.0.0', notes: 'Test release note body'};
   const options = {branch: 'master', repositoryUrl: `https://github.com/${owner}/${repo}.git`};
+  const untaggedReleaseUrl = `${env.GH_URL}/${owner}/${repo}/releases/untagged-123`;
   const releaseUrl = `${env.GH_URL}/${owner}/${repo}/releases/${nextRelease.version}`;
   const assetUrl = `${env.GH_URL}/${owner}/${repo}/releases/download/${nextRelease.version}/upload.txt`;
   const releaseId = 1;
@@ -160,7 +162,7 @@ test.serial('Publish a release with one asset and custom github url', async t =>
       body: nextRelease.notes,
       draft: true,
     })
-    .reply(200, {upload_url: uploadUrl, html_url: releaseUrl, id: releaseId})
+    .reply(200, {upload_url: uploadUrl, html_url: untaggedReleaseUrl, id: releaseId})
     .patch(`/repos/${owner}/${repo}/releases/${releaseId}`, {
       draft: false,
     })
@@ -190,6 +192,7 @@ test.serial('Publish a release with an array of missing assets', async t => {
   const pluginConfig = {assets: [emptyDirectory, {path: 'missing.txt', name: 'missing.txt'}]};
   const nextRelease = {version: '1.0.0', gitHead: '123', gitTag: 'v1.0.0', notes: 'Test release note body'};
   const options = {branch: 'master', repositoryUrl: `https://github.com/${owner}/${repo}.git`};
+  const untaggedReleaseUrl = `https://github.com/${owner}/${repo}/releases/untagged-123`;
   const releaseUrl = `https://github.com/${owner}/${repo}/releases/${nextRelease.version}`;
   const releaseId = 1;
   const uploadUri = `/api/uploads/repos/${owner}/${repo}/releases/${releaseId}/assets`;
@@ -203,7 +206,7 @@ test.serial('Publish a release with an array of missing assets', async t => {
       body: nextRelease.notes,
       draft: true,
     })
-    .reply(200, {upload_url: uploadUrl, html_url: releaseUrl, id: releaseId})
+    .reply(200, {upload_url: uploadUrl, html_url: untaggedReleaseUrl, id: releaseId})
     .patch(`/repos/${owner}/${repo}/releases/${releaseId}`, {
       draft: false,
     })