feat: allow specify url in release assets #322
Conversation
awcjack
changed the title
|
Is there something holding back this MR? |
|
forget created pull request |
lib/publish.js
Outdated
| throw error; | ||
| let _url = asset.url; | ||
| if (_url) { | ||
| // Allow loading variable from process.env load CI_JOB_ID for attaching CI artifact |
There was a problem hiding this comment.
Nice you considered this, too 👍
There was a problem hiding this comment.
I understand the idea behind this, but I don't like how this new propery is handled in a very special way. We already have a templating mechanism (via lodash) and I don't want to introduce another one. I'd suggest we switch to that for the URL and create a follow-up issue for using env vars in templates.
There was a problem hiding this comment.
Only merge issues to fix and then it looks good for me. (sorry for the late reply...)
@fgreinacher what do you think?
Add example and description of path in asset
|
Rebased (ran test for checking no merge error) and removed the variable code |
fgreinacher
changed the title
|
@awcjack Thanks a lot for your contribution, greatly appreciated! |
|
🎉 This PR is included in version 9.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This solve #154