Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(verify): gracefully handle options without validator #364

Merged
merged 1 commit into from Apr 14, 2022
Merged

fix(verify): gracefully handle options without validator #364

merged 1 commit into from Apr 14, 2022

Conversation

fgreinacher
Copy link
Contributor

Fixes #363

@fgreinacher
Copy link
Contributor Author

fgreinacher commented Apr 14, 2022 •
edited

@travi @JonasSchubert I'd suggest to tackle this in two steps:

  1. Merge this fix to unblock folks asap.
  2. Create a follow-up issue to refactor the option validation. IMO it's super brittle and we should clean it up properly so that we cannot run into these kinds of issue in the future. We should somehow encapsulate options, their validation and error messages better.

@fgreinacher fgreinacher requested a review from travi April 14, 2022 08:31
@travi travi merged commit 24a8fb9 into master Apr 14, 2022
@travi travi deleted the fix/ignore-options-without-validator branch April 14, 2022 14:52
@github-actions
Copy link

🎉 This PR is included in version 9.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@travi
Copy link
Member

travi commented Apr 14, 2022

i like this approach to getting folks unblocked. thanks for taking care of this!

@fgreinacher fgreinacher mentioned this pull request Apr 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travi travi travi approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: VALIDATORS[option] is not a function
2 participants
@fgreinacher @travi