Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency hpagent to v1 #374

Merged
merged 1 commit into from May 11, 2022
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 10, 2022

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
hpagent ^0.1.2 -> ^1.0.0 age adoption passing confidence

Release Notes

delvedor/hpagent

v1.0.0

Compare Source

Breaking changes:

Features:

  • Add timeout support - #​66

Fixes:

  • Fix TLS bug for TLS over TLS proxy - #​65
  • Do not url encode username and password - #​67

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@fgreinacher
Copy link
Contributor

Drop Node.js < 14 - #​68

This is theoretically a breaking change. But as it's inline the with the semantic-release version requirements I'd suggest to merge it without bumping major. WDYT @travi @JonasSchubert?

@fgreinacher fgreinacher self-requested a review May 11, 2022 16:24
@travi
Copy link
Member

travi commented May 11, 2022

we've already dropped that support, so we should be good to accept this within our current range:

"node": ">=14.17"

@travi
Copy link
Member

travi commented May 11, 2022

also, for awareness, this check should protect us from merging an update that defines a node support range that is more restrictive than ours (as long as the range is defined within engines for that package):

run: npx ls-engines

@fgreinacher
Copy link
Contributor

Perfect, just wanted to make sure I am not missing some corner case. Also thanks for pointing out the check!

@fgreinacher fgreinacher merged commit 45ad46d into master May 11, 2022
@fgreinacher fgreinacher deleted the renovate/hpagent-1.x branch May 11, 2022 16:32
@github-actions
Copy link

🎉 This PR is included in version 9.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants