Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to publish assets with url without specifying path #382

Closed
Krewedk0 opened this issue May 24, 2022 · 3 comments · Fixed by #387
Closed

Failing to publish assets with url without specifying path #382

Krewedk0 opened this issue May 24, 2022 · 3 comments · Fixed by #387
Labels

Comments

@Krewedk0
Copy link

Release 9.3.0 (#322) introduced a feature to publish assets with direct links when url field specified in asset.
But path field is still required for this to work, otherwise release fails with

The assets option (https://github.com/semantic-release/gitlab/blob/master/README.md#assets) must be an Array of Strings or Objects with a path property.

This check wasn't changed here https://github.com/semantic-release/gitlab/blob/master/lib/verify.js#L18
as path should be optional in this case, according to the readme.

@fgreinacher
Copy link
Contributor

@awcjack Can you have a look?

@awcjack
Copy link
Contributor

awcjack commented May 29, 2022

Didn't realize it when rebase
I will create pull request later

fgreinacher added a commit that referenced this issue May 31, 2022
Co-authored-by: Florian Greinacher <florian.greinacher@siemens.com>
@fgreinacher
Copy link
Contributor

fgreinacher commented May 31, 2022

🎉 This issue is resolved in version 9.3.2 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants