Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asset url containing ${nextRelease.version} not working/expanded #406

Closed
jagiella opened this issue Jun 17, 2022 · 2 comments · Fixed by #409
Closed

asset url containing ${nextRelease.version} not working/expanded #406

jagiella opened this issue Jun 17, 2022 · 2 comments · Fixed by #409

Comments

@jagiella
Copy link

jagiella commented Jun 17, 2022

I would like to create version dependent urls as release assets pointing to the specific file on an other filehosting server.

["@semantic-release/gitlab", {
      "assets": [
          {"url": "http://fileserver/${nextRelease.version}/update.zip", "label": "update file", "type": "other"}
      ]
}]

The release page nevertheless will contain the following link:

http://fileserver/$%7BnextRelease.version%7D/update.zip

For the asset label that seems to work as the documentation suggests, e.g.

{"path": "dist/asset.min.js", "label": "v${nextRelease.version}.js"}

But why not for the url?

@fgreinacher
Copy link
Contributor

This absolutely makes sense!

Happy to take a PR, probably very similar to #365.

@github-actions
Copy link

🎉 This issue has been resolved in version 9.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants