Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When package.json has "private": "true" setting, the plugin is not parsing it as true #369

Open
gr2m opened this issue May 30, 2021 · 3 comments

Comments

@gr2m
Copy link
Member

gr2m commented May 30, 2021

At least VS Code seams to think that both are valid, so I think we should fix it

image

@travi
Copy link
Member

travi commented May 31, 2021

from the docs, i would only expect the boolean form to work, rather than also supporting the string form.

to clarify, are you suggesting that what vscode is showing is suggesting that both types should work, or something else? i could certainly see reading it that way. i wonder where it gets its type understanding for the package.json from.

@gr2m
Copy link
Member Author

gr2m commented May 31, 2021

are you suggesting that what vscode is showing is suggesting that both types should work

yes. I don't know why VS Code thinks that "false" and "true" are valid values but it seems to be a built-in module, so I'd like to make it work with the string values and maybe log a warning. It would be nice to log an issue with the VS Code team but honestly I don't know where. @reconbot did you file an issue for the typeahead somewhere?

@reconbot
Copy link

I tweeted them but don't know where to file it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants