New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise the minimum required version of node (and transition to ESM) #259
Comments
semantic-release/release-notes-generator
Hi, is modification of the minimum required version should be in package.json in engines? |
yes, but there are more places you need to change. See this pull request for comparison, it also includes the change to ESM: Here is the commit which bumps the minimal required version: |
the changes should be in beta branch? |
no, but the pull request should be opened against the |
Hey, i tried with esm part but some test are not passing, related to proxyquire |
Ah yes we've seen this elsewhere. @travi suggested an alternative. Can you start a pull request with your current changes and we take it from there? |
found the comment. Can you try to replace proxyquire with https://github.com/testdouble/testdouble.js? |
the problem is this line
should it be?
|
I don't know, I havent used testdouble myself yet. Could you give it a try and see if the tests pass? |
not it doesn't, but now the error is not related to that line, but instead this
Error:
|
I can't look into it myself before Aug 3rd. I'd appreciate if you or someone else could dig into it and try to figure out the errors |
🎉 This issue has been resolved in version 10.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
See for reference: semantic-release/semantic-release#2055
engines-strict
is enforced in the CI of each project to reduce the cases where incompatible dependencies are installed outside of our supported range (example)Bonus:
semantic-release/semantic-release
semantic-release#2055Pull request welcome! Just comment below if you'd like to work on it and we will assign the issue to you. Thank you for your help 💐
The text was updated successfully, but these errors were encountered: