Skip to content

Commit

Permalink
fix: use correct ci branch context (#1521)
Browse files Browse the repository at this point in the history
  • Loading branch information
iamogbz committed Jun 25, 2020
1 parent a465801 commit 0f0c650
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion index.js
Expand Up @@ -26,7 +26,8 @@ marked.setOptions({renderer: new TerminalRenderer()});
/* eslint complexity: off */
async function run(context, plugins) {
const {cwd, env, options, logger} = context;
const {isCi, branch: ciBranch, isPr} = context.envCi;
const {isCi, branch, prBranch, isPr} = context.envCi;
const ciBranch = isPr ? prBranch : branch;

if (!isCi && !options.dryRun && !options.noCi) {
logger.warn('This run was not triggered in a known CI environment, running in dry-run mode.');
Expand Down
4 changes: 2 additions & 2 deletions test/index.test.js
Expand Up @@ -1258,7 +1258,7 @@ test('Allow local releases with "noCi" option', async (t) => {

const semanticRelease = requireNoCache('..', {
'./lib/get-logger': () => t.context.logger,
'env-ci': () => ({isCi: false, branch: 'master', isPr: true}),
'env-ci': () => ({isCi: false, branch: 'master', isPr: false}),
});
t.truthy(
await semanticRelease(options, {
Expand Down Expand Up @@ -1357,7 +1357,7 @@ test('Returns false if triggered by a PR', async (t) => {

const semanticRelease = requireNoCache('..', {
'./lib/get-logger': () => t.context.logger,
'env-ci': () => ({isCi: true, branch: 'master', isPr: true}),
'env-ci': () => ({isCi: true, branch: 'master', prBranch: 'patch-1', isPr: true}),
});

t.false(
Expand Down

0 comments on commit 0f0c650

Please sign in to comment.