Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent false positive secret replacement #1562

Merged
merged 1 commit into from May 24, 2020

Conversation

nickshine
Copy link
Contributor

Resolve #1558

lib/hide-sensitive.js Outdated Show resolved Hide resolved
Resolve semantic-release#1558

Co-authored-by: Gregor Martynus <gregor@martynus.net>
Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gr2m gr2m merged commit eed1d3c into semantic-release:master May 24, 2020
@semantic-release-bot
Copy link
Collaborator

🎉 This PR is included in version 17.0.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickshine nickshine deleted the hide-sensitive-golang-fix branch May 24, 2020 19:02
aquariuslt pushed a commit to aquariuslt/semantic-release that referenced this pull request Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positives with hide-sensitive [secure] output
3 participants