You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current regular expression that is used to parse repository URLs does not handle custom ports properly.
For example, given the URL git@localhost:2080/git/test.git, the regexp will ouput the following groups:
auth: git
host: localhost
path: 2080/git/test.git
If the URL works out of the box, this codepath will be skipped and it will still work.
However, given a case where the URL needs to be converted to HTTP(s) with basic auth information, it will create an invalid URL : https://git@localhost/2080/git/test.git.
Expected behavior
The port should be parsed correctly. This can be done easily by customising the regexp a little, like I did in #1671.
Environment
semantic-release version: 17.2.1, master
CI environment: not relevant
Plugins used: not relevant
semantic-release configuration: not relevant
CI logs: not relevant
The text was updated successfully, but these errors were encountered:
Current behavior
The current regular expression that is used to parse repository URLs does not handle custom ports properly.
For example, given the URL
git@localhost:2080/git/test.git
, the regexp will ouput the following groups:auth:
git
host:
localhost
path:
2080/git/test.git
If the URL works out of the box, this codepath will be skipped and it will still work.
However, given a case where the URL needs to be converted to HTTP(s) with basic auth information, it will create an invalid URL :
https://git@localhost/2080/git/test.git
.Expected behavior
The port should be parsed correctly. This can be done easily by customising the regexp a little, like I did in #1671.
Environment
master
The text was updated successfully, but these errors were encountered: