-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose getLastRelease step to plugins #1690
Comments
the use case that you describe seems to avoid versioning packages semantically, which is a core goal of semantic-release. please keep in mind that semantic-release is not simply a generic tool for automated package publishing but a tool to encourage proper semantic-versioning and to make doing so properly as simple as possible. forcing a package's version to rely on the version of some external source means that the version does not semantically communicate the impact of the changes in that package. while we recognize that the flexibility of the pieces of this toolset make it almost a fit for some use cases outside of the intended/supported ones, we have to be careful to keep that configurability in check to reduce our maintenance burden for supporting unsupported use cases. we appreciate the clear issues that you opened and the work you put into your PR, but we dont think this use case is a fit for semantic-release. in the future, we suggest opening an issue with the primary goal first in order to gain alignment before putting in too much effort into an implementation. |
Semver, https://semver.org/, does not disallow additional bumps in version. It only states:
|
This also gives more flexibility in migration and allow developers customization to bypass bugs or avoid having to recreate some specific git state. The calculation of the last release is unnecessarily strict in my opinion. The getLastRelease leads to many issues: |
This would also allow support for gitflow, #1231 (comment). |
we really do not want to support I'm not saying that we won't change our mind in future, but not at this point |
Leaving this here for anyone in a similar situation: The plugin https://github.com/saitho/semantic-release-backmerge solves the issue of gitflow compatibility by merging |
New feature motivation
The
major.minor
version of my package is triggered from an external source. I want to use this as the last release and allow semantic-release to only be concerned with the patch and prerelease versions. Related: semantic-release/commit-analyzer#180Additionally, migrating repositories or trying to start at a specific version is not well supported by semantic-release. This functionality would allow more flexibility.
New feature description
Allow plugins to determine the last release and set
context.lastRelease
.New feature implementation
The text was updated successfully, but these errors were encountered: