Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escape uri encoded symbols #1697

Conversation

dekhanov
Copy link
Contributor

closes #1694

Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just waiting for Travis to complete. We are in the process of replacing travis with Actions, because Travis is no longer usable for Open Source projects.

@gr2m
Copy link
Member

gr2m commented Nov 18, 2020

as the PR only adds a unit test, could you confirm if this change is resolving the problem you are experiencing?

@travi
Copy link
Member

travi commented Nov 19, 2020

Also, it looks like you're commit is not associating with your GitHub account. Would you mind either adding the email used for the commit to your account or amending your commit to use an email that is already associated?

@dekhanov dekhanov force-pushed the bugfix/issue-1694-Invalid-regular-expression-error branch from 1016bc2 to 04756da Compare November 19, 2020 07:55
@dekhanov
Copy link
Contributor Author

@travi good catch, thank you! I've changed the email.
@gr2m Yes, I confirm that this little change in hide-sensitive fixes that problem.

I worry that an error in hide-sensitive was thrown silently, without any logs. Maybe this worth an additional issue? What do you think?

@gr2m
Copy link
Member

gr2m commented Nov 19, 2020

let's merge this

I worry that an error in hide-sensitive was thrown silently, without any logs. Maybe this worth an additional issue? What do you think?

The current implementation is not very elegant, I've been discussing with @travi if there is a better way

For now I think we should merge this as is to address the regression

@gr2m gr2m merged commit f8f8fbc into semantic-release:master Nov 19, 2020
@semantic-release-bot
Copy link
Collaborator

🎉 This PR is included in version 17.2.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Semantic-release silently fails on v17.2.3
4 participants