Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize ci: false into noCi: true after configs get merged #1732

Merged
merged 1 commit into from Jan 13, 2021

Conversation

dominykas
Copy link
Contributor

This makes sure that options.ci is respected even when set inside a shareable config.

Closes #1728.

This makes sure that options.ci is respected even when set inside a shareable config
Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Dominykas!

@gr2m
Copy link
Member

gr2m commented Jan 13, 2021

CI error is unrelated. It will be resolved once we figure out #1699

@gr2m gr2m merged commit 21c151f into semantic-release:master Jan 13, 2021
@dominykas dominykas deleted the extended-config-no-ci branch January 13, 2021 15:53
@semantic-release-bot
Copy link
Collaborator

🎉 This PR is included in version 17.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Xunnamius pushed a commit to Xunnamius/semantic-release-atam that referenced this pull request Feb 11, 2021
…mantic-release#1732) thanks @dominykas

This makes sure that options.ci is respected even when set inside a shareable config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot disable CI checks in shareable configurations
3 participants