feat(config): Use cosmiconfig defaults to support .cjs config files #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This change adds support for `*.cjs` config files by removing the explicit use of `searchPlaces` options and relying and the default search places generated by `cosmicconfig`. As per the docs for [`cosmicconfig`][cc], the defaults include all the extensions/formats previously supported by semantic-release in addition to the new .cjs variants. Resolves [semantic-release#1814][issue]. [issue]: semantic-release#1814 [cc]: https://github.com/davidtheclark/cosmiconfig#searchplaces
opiation
force-pushed
the
fix/support-cjs-using-cosmicconfig-defaults
branch
from
a473f31
to
440a6b4
Compare
|
thank you for investigating and tracking down these details. i did dig a little bit to try to understand why they were defined explicitly before, but even the version that resulted in the addition appears to have supported similar defaults. from what i can tell this change aligns with the original intent fro before that change too. |
travi
changed the title
|
🎉 This PR is included in version 17.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Mar 7, 2021
Closed
Closed
Closed
This was referenced Mar 12, 2021
Merged
chore(deps-dev): bump semantic-release from 17.1.1 to 17.4.2
dot-build/rollup-plugin-includepaths#62
Closed
Closed
chore(deps-dev): bump semantic-release from 17.2.3 to 17.4.2
michael-wolfenden/serverless-bundler#70
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for
*.cjsconfig files by removing the explicit use ofsearchPlacesoptions and relying and the default search places generated bycosmicconfig. As per the docs forcosmicconfig, the defaults include all the extensions/formats previously supported by semantic-release in addition to the new .cjs variants.Resolves #1814.