Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't install version 17.4.5: peer dependencies are incorrect #2086

Closed
kaiyoma opened this issue Aug 23, 2021 · 2 comments
Closed

Can't install version 17.4.5: peer dependencies are incorrect #2086

kaiyoma opened this issue Aug 23, 2021 · 2 comments

Comments

@kaiyoma
Copy link

kaiyoma commented Aug 23, 2021

Current behavior

Installing this package fails with pnpm:

ERROR  semantic-release: marked-terminal@4.1.1 requires a peer of marked@^1.0.0 || ^2.0.0 but version 3.0.0 was installed.

Expected behavior

The package should install.

Environment

  • semantic-release version: 17.4.5
@travi
Copy link
Member

travi commented Aug 23, 2021

thanks for the report @kaiyoma. we added engine-strict to our ci checks to avoid situations like this, but didnt realize that there is a bug with npm that prevents the expected failure with npm ci.

i've begun the process of reverting and updated the check to instead use npx ls-engines: #2087. i'll close this issue, but you can follow there for progress

@travi travi closed this as completed Aug 23, 2021
@kaiyoma
Copy link
Author

kaiyoma commented Aug 23, 2021

@travi Sounds good, thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants