fix(engines): fixed defined node version to account for the higher requirement from the npm plugin #2088
Conversation
…quirement from the npm plugin
…gines` since `engine-strict` apparently does not fail `npm ci` as was expected
…ines` definition and to clean up a few cases that were even further out of date
|
well, this is frustrating. this is passing locally. i wonder if there is some sort of platform-dependent optional dependency that requires node v12 and doesn't get installed on macOS |
…of the matrix since it is not environment specific, but instead compares the range to that of the dependencies
|
the problem seems unlikely to be OS based. the |
…acos in the hopes that it will avoid failures for an unknown dependency with incompatible engines that isnt installed on macos
…supported node versions
…uns on macos" This reverts commit bba0c17.
| @@ -48,4 +46,6 @@ jobs: | |||
| with: | |||
| cache: npm | |||
There was a problem hiding this comment.
I think we need to add the node version explicitly here
| cache: npm | |
| cache: npm | |
| node-version:10.19.0 |
There was a problem hiding this comment.
i dont think this needs to change from what we had before. ls-engines doesn't do its comparison against the current execution context like we expected engine-strict to do. instead, it analyzes the effective engines range of the dependency tree and compares it against the project's declared engines range. it can do that in any version of node that can execute ls-engines. does this explanation address the reason you were expecting an explicit version to be declared for this job?
There was a problem hiding this comment.
ah got it! In that case I'd set node-version to 16. Otherwise we get the OS default node version that might change any time. I probably set this up myself without setting node-version explicitly, but I'm doing that now everywhere. But we can do that later, it's outside of the scope here
There was a problem hiding this comment.
yeah, makes sense. since i like to keep a record of a preferred development node version in a .nvmrc file in the repo, i typically take care of this by referencing the value from that file in non-matrix jobs, like https://github.com/form8ion/project/blob/b05d76fa60e4c648efbaf98d8f68e69d0155da94/.github/workflows/node-ci.yml#L43
There was a problem hiding this comment.
i'll plan to get the explicit v16 added to that job as part of our wip v16 branch
There was a problem hiding this comment.
nevermind, looks like you already have a PR open for this in #2092 👍🏼
|
🎉 This PR is included in version 17.4.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 18.0.0-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
enginesdefinition to account for the fact that@semantic-release/npmalready required>=10.19, making the definition in this package effectively incorrectenginesusingls-engines