Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node-versions): raised the minimum required node version to v18 #2620

Merged
merged 1 commit into from Nov 21, 2022

Conversation

travi
Copy link
Member

@travi travi commented Nov 19, 2022

in accordance with our node support policy:
https://semantic-release.gitbook.io/semantic-release/support/node-support-policy

BREAKING CHANGE: Node v18 or greater is now required. Please refer to
https://semantic-release.gitbook.io/semantic-release/support/node-version for recommended options
for releasing with a supported node version.

for #2543

in accordance with our node support policy:
https://semantic-release.gitbook.io/semantic-release/support/node-support-policy

BREAKING CHANGE: Node v18 or greater is now required. Please refer to
https://semantic-release.gitbook.io/semantic-release/support/node-version for recommended options
for releasing with a supported node version.

for #2543
@travi travi requested a review from gr2m November 19, 2022 06:05
Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels great

@gr2m gr2m merged commit 8a0d8be into beta Nov 21, 2022
@gr2m gr2m deleted the node-18 branch November 21, 2022 05:23
@github-actions
Copy link

🎉 This PR is included in version 20.0.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

🎉 This PR is included in version 20.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@benmccann
Copy link

This feels a bit too aggressive. I would understand not wanting to test on older versions, but using engines to ban people from running on a supported LTS is a bit much in my opinion. Our project still supports Node 16 as its an LTS that's supported until September. Would it be possible to add back Node 16 support in the engines field (or alternately to remove the engines field and simply drop testing older versions)?

@travi
Copy link
Member Author

travi commented May 6, 2023

We recommend releasing from a separate job from the one you do your verification in. This enables verifying in a matrix of the versions supported by your package and then releasing after all have passed.

https://semantic-release.gitbook.io/semantic-release/support/node-version#recommended-solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants