Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] release.config.js not found by default 22.0.9 #3089

Closed
askidelskiy opened this issue Dec 5, 2023 · 2 comments
Closed

[Bug] release.config.js not found by default 22.0.9 #3089

askidelskiy opened this issue Dec 5, 2023 · 2 comments

Comments

@askidelskiy
Copy link

askidelskiy commented Dec 5, 2023

Current behavior

#3072 Introduces the following breaking change:

Meta config files (i.e. config.js and similar) are not looked for in the current working directory anymore. Instead, it looks in the .config subfolder.

Therefore release.config.js in the working directory is not picked up, breaking release flow for all repositories that didn't store their configs in .config or specified the config location

Expected behavior

Attempt to fetch config files from working directory so that existing users have time to switch to using .config folder. Or another workaround that would enable using currently existing config files without restructuring repositories.

semantic-release version

22.0.9

CI environment

GHA

Plugins used

git
github
changelog

semantic-release configuration

module.exports = {
    "branches": [
        {name: "main"},
        {name: 'qa', prerelease: true},
        {name: 'internal', prerelease: true}
    ],
    ...
}

CI logs

code: 'ERELEASEBRANCHES',
      details: 'A minimum of 1 and a maximum of 3 release branches are required in the [branches configuration](https://github.com/semantic-release/semantic-release/blob/master/docs/usage/configuration.md#branches).\n' +
        '\n' +
        'This may occur if your repository does not have a release branch, such as `master`.\n' +
        '\n' +
        'Your configuration for the problematic branches is `[]`.',
@askidelskiy askidelskiy changed the title [Bug] release.config.js not found by default [Bug] release.config.js not found by default 22.0.9 Dec 5, 2023
@travi
Copy link
Member

travi commented Dec 6, 2023

thanks for reporting!

#3072 Introduces the following breaking change:

Meta config files (i.e. config.js and similar) are not looked for in the current working directory anymore. Instead, it looks in the .config subfolder.

i read that in the release notes of v9 of cosmiconfig, but misinterpreted it to only apply specifically to use of a .config.js file and didnt think it would apply to a release.config.js file.

since it is indeed a breaking change for our users, the upgrade has been reverted in https://github.com/semantic-release/semantic-release/releases/tag/v22.0.10. we will be upgrading to that version, but it will be released as a major version to account for the breaking change.

@gr2m
Copy link
Member

gr2m commented Dec 11, 2023

so sorry I accidentally reverted the revert, I'm gonna .. revert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants