Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Cannot find module '../build/tries/current/icann.complete.json' #816

Closed
unlight opened this issue Jun 9, 2018 · 11 comments
Closed

Comments

@unlight
Copy link

unlight commented Jun 9, 2018

Current behavior

{ Error: Cannot find module '../build/tries/current/icann.complete.json'
at Function.Module._resolveFilename (module.js:547:15)
at Function.Module._load (module.js:474:25)
at Module.require (module.js:596:17)
at require (internal/module.js:11:18)
at Object.<anonymous> (/home/rof/src/github.com/unlight/ref-holder/node_modules/semantic-release/node_modules/git-url-parse/node_modules/parse-domain/lists/icann.complete.js:5:28)
at Module._compile (module.js:652:30)
at Object.Module._extensions..js (module.js:663:10)
at Module.load (module.js:565:32)
at tryModuleLoad (module.js:505:12)
at Function.Module._load (module.js:497:3) code: 'MODULE_NOT_FOUND' }

Expected behavior

No error

Environment

> npm ls semantic-release git-url-parse
`-- semantic-release@15.5.1
  +-- @semantic-release/release-notes-generator@6.0.12
  | `-- git-url-parse@9.0.1  deduped
  `-- git-url-parse@9.0.1
@pvdlg
Copy link
Member

pvdlg commented Jun 9, 2018

Does it happens when you run npm install? Or when you run semantic-release?
Have you tried to delete your node_modules folder and your lockfile and re-install?

@unlight
Copy link
Author

unlight commented Jun 9, 2018

It happens while runnig semantic-release.

Have you tried to delete your node_modules folder and your lockfile and re-install?

I do not have lockfile.

I cannot remove node_modules on CI side (codeship) (reset cache did not help).
I can try to do it locally, but it makes no much sense. I need working it on CI.

@unlight
Copy link
Author

unlight commented Jun 11, 2018

peerigon/parse-domain#35

@jhnns
Copy link

jhnns commented Jun 11, 2018

This was introduced by change made in our module parse-domain (which is apparently a transitive dependency of semantic-release). You can probably close it here as it is not related to semantic-release itself.

@pvdlg
Copy link
Member

pvdlg commented Jun 28, 2018

It should be fixed when peerigon/parse-domain#39 lands.

@Aghassi
Copy link
Contributor

Aghassi commented Jul 5, 2018

@jhnns Any update as to when peerigon/parse-domain#39 will be merged?

@pvdlg
Copy link
Member

pvdlg commented Jul 9, 2018

An alternative and probably better solution here: IonicaBizau/git-url-parse#80

@nkristoffersen
Copy link

I wanted to try semantic-release but now find I cannot run it in CI due to this issue with parse-domain. Ironic since this is the exact situation semantic versioning is trying to solve :-)

@IonicaBizau
Copy link

Sorry for the delay—I merged the @pvdlg's pull request. :)

@pvdlg
Copy link
Member

pvdlg commented Jul 16, 2018

Fixed by #860

@pvdlg pvdlg closed this as completed Jul 16, 2018
@kimsagro1
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants