Skip to content
This repository has been archived by the owner on Nov 13, 2021. It is now read-only.

Incorrect bump when major is v0 #137

Open
mandrean opened this issue May 9, 2019 · 2 comments
Open

Incorrect bump when major is v0 #137

mandrean opened this issue May 9, 2019 · 2 comments

Comments

@mandrean
Copy link

mandrean commented May 9, 2019

If a project is on, say, v0.2.0 and you have a breaking change-commit, running semantic-rs suggests the new version should now be v1.0.0:

$ semantic-rs -w=no -r=no

semantic.rs 馃殌
Performing preflight checks now
Checks done. Everything is ok
Current version: 0.2.0
Analyzing commits
Commits analyzed. Bump would be Major
New version would be: 1.0.0

But according to http://semver.org, you bump the 2nd component for breaking changes when you are at major v0

Expected: v0.2.0 -> v0.3.0
Actual: v0.2.0 -> v1.0.0

@badboy
Copy link
Member

badboy commented May 9, 2019

At major version 0 all bets are off anyway and, if we're going by the spec directly, everything is considered breaking anyway.
semantic-rs is not really built to support that part of development and more suited to once you are stable (v1.0.0).
I totally see that we could support that use case though.

(Development on semantic is a bit halted right now due to us not having time an energy to move it forward)

@mandrean
Copy link
Author

mandrean commented May 9, 2019

Created a PR for it, works well for me locally on my project. Please have a look!

#138

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants