Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more PT-BR translations and fix existing translations #430

Merged
merged 7 commits into from
Dec 3, 2023

Conversation

jlucfarias
Copy link
Contributor

PR Checklist

  • This PR doesn't modify the files in the spec dir.
  • This PR passes npm run lint.
  • (Optional) If you're willing to help reviews about your language's translations, add your name to the TRANSLATORS.md.

This PR supercede #384 and fixes #425

@JohnTitor
Copy link
Member

@LucasHT22 Could you review this when you have time? Thanks in advance!

Copy link
Contributor

@LucasHT22 LucasHT22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great translation @jlucfarias ! I left some comments, if you disagree with anything, please, let me know.

uma versão menor foi incrementado, a versão de correção DEVE ser reinicializada
como 0 (zero). Por exemplo: 1.1.3 -> 2.0.0 e 2.1.7 -> 2.2.0.

1. A pre-release version number MAY be denoted by appending an arbitrary
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From here below it is not translated, since you translated the beginning, I suggest translating the rest too:)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ sorry for that

- [Silas Ribas Martins](https://github.com/silasrm)
- [Rogerio Prado de Jesus](https://github.com/rogeriopradoj)
- [João Lucas Farias](https://github.com/jlucfarias)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any reason to have translation specifications/translators names here, it already exists in https://semver.org/lang/pt-BR/#sobre , would make it confusing when adding new names

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applies to other files too

@JohnTitor
Copy link
Member

@jlucfarias Could you check the above review comments? Thanks!

@jlucfarias
Copy link
Contributor Author

Suggestions applied now, sorry for the late response

Copy link
Contributor

@LucasHT22 LucasHT22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me:)

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both for contributing and reviewing!

@JohnTitor JohnTitor merged commit a6b5c60 into semver:gh-pages Dec 3, 2023
1 check passed
@jlucfarias jlucfarias deleted the pt-br branch December 4, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A small problem in PT-BR translation
3 participants