Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: Rename positive digit in the EBNF ruleset to nonzero digit #665

Open
dtonhofer opened this issue Feb 22, 2021 · 7 comments · May be fixed by #673
Open

Suggestion: Rename positive digit in the EBNF ruleset to nonzero digit #665

dtonhofer opened this issue Feb 22, 2021 · 7 comments · May be fixed by #673
Labels
question Question about SemVer and use cases update Update current idea/rule

Comments

@dtonhofer
Copy link

I suggest to rename the positive digit in the EBNF ruleset to nonzero digit

Because "positive" is not really an adjective applicable to a "digit": it's a digit, not a number.

So we have the digit "zero" expressed by "0" and the other digits, the nonzero digits
@ghost
Copy link

ghost commented Feb 26, 2021 •
edited by ghost

This is pretty easy to fix and mathematically correct. @dtonhofer do you mind putting in a PR?

@dtonhofer
Copy link
Author

Okay, will do it later today (hopefully).

dtonhofer added a commit to dtonhofer/semver that referenced this issue Feb 28, 2021
@dtonhofer
Changed positive digit to non-zero digitas per issue semver#665
8533acf 
Note:

- I have not upgrade the version at the top of the page, still at 2.0.0. Technically, should become 2.0.1 I suppose.
- I have used the name `non-zero digit` rather than `nonzero digit` similar to the existing `non-digit`.It's a matter of taste.
@dtonhofer
Copy link
Author

dtonhofer commented Feb 28, 2021 •
edited

Submitted a pull request.

#673

Note the following:

  • I have not upgrade the version at the top of the page, still at 2.0.0. Technically, should become 2.0.1 (?)
  • I have used the name non-zero digit rather than nonzero digit similar to the existing non-digit.It's a matter of taste.

@ghost
Copy link

ghost commented Mar 1, 2021

Yes, 2.0.1.

@dtonhofer
Copy link
Author

Changed. Seems to have updated the pull request accordingly.

@alexandrtovmach alexandrtovmach added question Question about SemVer and use cases update Update current idea/rule labels Jun 14, 2021
@roniesha1994
Copy link

@dtonhofer
Copy link
Author

Good day. What happened to this? It seems to be in limbo. Accept? Reject?

@JohnTitor JohnTitor linked a pull request Jul 21, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Question about SemVer and use cases update Update current idea/rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed positive digit to non-zero digitas per issue #665 dtonhofer/semver
5 participants
@dtonhofer @alexandrtovmach @roniesha1994 and others