remove req.session.cookie.hasLongExpires because YAGNI #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what problems does it cause? a test would be nice for the problems it cuases |
|
@jonathanong Problem discussed in #859 |
|
@jonathanong @visionmedia ok, tests added. |
ghost
assigned
|
i'd like to merge this, but i don't know why it was added in the first place |
|
@visionmedia do you know why this was added in the first place? |
|
okay, since i've gotten no answers, i'll just merge this. unfortunately, it needs a rebase :( |
|
I think this pre-dates the hashing |
|
@undoZen if you want this in soon, you have to rebase, otherwise you can wait until v3 when i change up cookies. |
It's not only not needed, but also cause problems. senchalabs#859
|
@jonathanong ok, I've done rebase my branch. |
|
very nice. thanks! |
jonathanong
added a commit
that referenced
this pull request
Dec 11, 2013
remove req.session.cookie.hasLongExpires because YAGNI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not only not needed, but also cause problems.
#859