Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ending default 404 handler with a newline #972

Merged
merged 1 commit into from Dec 6, 2013

Conversation

rlidwka
Copy link
Contributor

@rlidwka rlidwka commented Dec 6, 2013

I suggest to add a newline after a default 404 handler.

It doesn't matter if you're getting this using a browser, but if you request a page in console, weird thing would happen:

alex@server:~/bin$ curl http://localhost:4873/non/existent/page
Cannot GET /non/existent/pagealex@server:~/bin$ 

Not a big issue, I'm just tired of seeing this. :)

@jonathanong
Copy link
Contributor

lol ok

jonathanong added a commit that referenced this pull request Dec 6, 2013
ending default 404 handler with a newline
@jonathanong jonathanong merged commit a181efd into senchalabs:master Dec 6, 2013
@dougwilson
Copy link
Contributor

Seems like you could simply do

alex@server:~/bin$ curl http://localhost:4873/non/existent/page; echo
Cannot GET /non/existent/page
alex@server:~/bin$ 

anyway :)

@rlidwka
Copy link
Contributor Author

rlidwka commented Dec 6, 2013

Oh wow, that was fast... I guess people are tired of bike sheds.

Yeah, echo helps when you know that an output doesn't have a newline. But if it already messed with your output, it's too late. :)

@dougwilson
Copy link
Contributor

@rlidwka I was just giving a tip as well :) I agree with the acceptance of this merge, because there is no real argument against adding the trailing new line anyway :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants