Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new line for comments and id selectors #3

Open
scharmetant opened this issue Oct 18, 2011 · 5 comments
Open

new line for comments and id selectors #3

scharmetant opened this issue Oct 18, 2011 · 5 comments

Comments

@scharmetant
Copy link

Hi,
lib working great, exept for theses: I have noticed that cssbeautify will not create a new line for comments in the CSS:
/* My comment here */ .a-selector {etc..

Also, same thing happens with slectors starting by #:

a-unique-id span { etc...

@ariya
Copy link

ariya commented Oct 18, 2011

Thanks for the report! We will tackle this in the earliest convenient time.

@ariya
Copy link

ariya commented Oct 19, 2011

Selectors starting with # should work now!

@scharmetant
Copy link
Author

Nice,
still doesn't shoot when a comment is ahead though;

#search-submit { <-- this is OK
width: 50px;
height: 22px;
border: none;
background: #B9B9B9;
color: #000000;
} /* Menu */#menu { <-- comment stay inline, as well as next #selector
width: 940px;
height: 80px;
margin: 0 auto;
padding: 0;
}

I have spent more time experiencing your script, it seems efficient, unobtrusive and fast, by far the best I found for the job. I will post an issue with 1 or 2 killer features you may add to make it Top of the world

@ariya
Copy link

ariya commented Oct 19, 2011

The comment-followed-by-# issue is because block comment in general has not fixed yet (optionally to place it into its own separated line). This is next in the list.

More feedback is welcomed :)

@ariya
Copy link

ariya commented Oct 26, 2011

Do you have an idea on how to place the comment? I played with different ideas on where to split and indent the comment, it seems quite challenging to get the heuristics right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants