Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go Modules Support #417

Open
jacklaaa89 opened this issue Oct 27, 2020 · 4 comments · May be fixed by #441
Open

Go Modules Support #417

jacklaaa89 opened this issue Oct 27, 2020 · 4 comments · May be fixed by #441
Labels
status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap

Comments

@jacklaaa89
Copy link

Issue Summary

Is there any plans in the future to support go modules. As at the minute the import is marked as incompatible when using any version above v1

for example the import should be renamed to have the major version suffixed:

github.com/sendgrid/sendgrid-go v3.5.0+incompatible => github.com/sendgrid/sendgrid-go/v3 v3.5.0
@coolaj86 coolaj86 mentioned this issue Oct 28, 2020
Closed
8 tasks
@childish-sambino
Copy link
Contributor

This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog.

@childish-sambino childish-sambino added status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap labels Oct 29, 2020
@bonesyo
Copy link

bonesyo commented Feb 3, 2021

+1

@shwetha-manvinkurke shwetha-manvinkurke linked a pull request Oct 8, 2021 that will close this issue
Draft
@avarghese-sqsp
Copy link

Can we prioritize this issue please? The use of Go modules is now mainstream and a good number of packages in the Go ecosystem has already migrated.

@shwetha-manvinkurke
Copy link
Contributor

@avarghese-sqsp we are working on it. Since this is going to be a major version release, we need to work through some pre-reqs before we can go ahead and make the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: add go modules support sendgrid/sendgrid-go
WIP: update to go mod coolaj86/sendgrid-go
5 participants
@jacklaaa89 @bonesyo @shwetha-manvinkurke @childish-sambino @avarghese-sqsp