Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mssql): change to uppercase on the described table #12253

Merged
merged 1 commit into from May 14, 2020
Merged

fix(mssql): change to uppercase on the described table #12253

merged 1 commit into from May 14, 2020

Conversation

arnaud-moncel
Copy link

@arnaud-moncel arnaud-moncel commented May 14, 2020

Pull Request check-list

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Fix an error on the described table for mssql with a case sensitive collation.

This PR backports #12212 to v5.

@arnaud-moncel
Copy link
Author

The tests fail with MariaDd dialect 🤕, I didn't change anything on that.

@sushantdhiman sushantdhiman merged commit 8a3827d into sequelize:v5 May 14, 2020
@arnaud-moncel arnaud-moncel deleted the fix/mssql-describetable branch May 14, 2020 10:28
@sushantdhiman
Copy link
Contributor

🎉 This PR is included in version 5.21.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants