Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add support for Oracle DB 18c CI #15016

Merged
merged 49 commits into from Sep 22, 2022
Merged

fix: Add support for Oracle DB 18c CI #15016

merged 49 commits into from Sep 22, 2022

Conversation

nilabja-bhattacharya
Copy link

@nilabja-bhattacharya nilabja-bhattacharya commented Sep 19, 2022 •
edited

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

PR to support the CI of the minimal supported Oracle DB version

Todos

sudarshan12s and others added 30 commits June 14, 2022 15:22
@sudarshan12s
feat(oracle): add oracle dialect support (#1)
3ff1598 
* feat(oracle): add oracle dialect support
@sudarshan12s
Merge branch 'sequelize:v6' into v6
01ade20
@sudarshan12s
fix: addressing review comments (#7)
2cda49b 
* fix: addressing review comments
@sudarshan12s
fix: minor fixes done (#9)
42ff129 
* fix: minor fixes to the review comments
@sudarshan12s
fix: merge from sequelize-v6
0dba368
@sudarshan12s
fix: enable newly added unit tests for Oracle dialect
1ae6673
@sudarshan12s
fix: remove dangling comma (#13)
478728d 
* fix: doc gen is fixed
@sudarshan12s
fix: autogenerate the primary constraint name (#14)
a9c456e 
* fix: autogenerate the primary constraint name
@sudarshan12s
Merge branch 'v6' into v6
8f6a2d2
@sudarshan12s
fix: remove trailing comma
4cc8ace
@sudarshan12s
Merge branch 'sequelize:v6' into v6
b1beb88
@sudarshan12s
Merge branch 'sequelize:v6' into v6
a076945
@sudarshan12s
fix: make changes to ORADERBY as per v6 sync
336ef8e
@sudarshan12s
Merge branch 'sequelize:v6' into v6
fcdd47f
@sudarshan12s
fix: move test-unit-oracle above test-unit-all
9c0de49
@sudarshan12s
Merge branch 'sequelize:v6' into v6
7ad96bf
@sudarshan12s
fix: rename getInsertQueryReturnIntoBinds to
1213de3 
  populateInsertQueryReturnIntoBinds
@sudarshan12s
fix: reorder parameters for function populateInsertQueryReturnIntoBinds
afedbf6
@sudarshan12s
fix: incorporated review comments (#16)
084cd81 
* fix: incorporated review comments
@sudarshan12s
fix: modify string empty check with !
f0a5494
@nilabja-bhattacharya
feat: support for Oracle DB 18c
f875a81
@nilabja-bhattacharya
Oracle DB version change
07e9e4e
@nilabja-bhattacharya
added stop-oracle for 18
2a74d0a
@nilabja-bhattacharya
fix: changes to DB version query
9bda36b
@nilabja-bhattacharya
fix: cleanup
4b0f35c
@nilabja-bhattacharya
fix: describetable query fix
f18f5e0
@nilabja-bhattacharya
fix: dbVersion to remove round trip and 18.4 json test fix
1bcd7c9
@nilabja-bhattacharya
fix: resolved merge conflict
d7851c0
@nilabja-bhattacharya
fix: removed dbversion
953a820
@nilabja-bhattacharya
fix: removed comment
fadf2fb
@nilabja-bhattacharya nilabja-bhattacharya changed the title fix: Support for Oracle DB 18c CI fix: Add support for Oracle DB 18c CI Sep 19, 2022
sdepold
sdepold previously approved these changes Sep 19, 2022
View reviewed changes
@sdepold sdepold self-requested a review September 19, 2022 18:00
@sdepold
Copy link
Member

sdepold commented Sep 19, 2022

Hm. Seems the failing tests are consistent across the both oracle versions?

@nilabja-bhattacharya
Copy link
Author

nilabja-bhattacharya commented Sep 19, 2022 •
edited

The tests that failed in the CI are flaky; they should be fixed with a re-run.

WikiRik
WikiRik reviewed Sep 20, 2022
View reviewed changes
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few comments but they are non blocking. Would be nice if you could work on these

dev/oracle/18-slim/privileges.sql Outdated Show resolved Hide resolved
src/dialects/oracle/index.js Show resolved Hide resolved
@nilabja-bhattacharya
Copy link
Author

There has been a flaky failure in 2 DBs, it would be good to re-run to failed jobs. Thanks.

WikiRik
WikiRik reviewed Sep 21, 2022
View reviewed changes
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment, but I think after that we should be good to merge

package.json Outdated Show resolved Hide resolved
WikiRik
WikiRik approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I do have some points for additional refactor but I'll take those up as part of backporting CI changes that we've done on main to v6.
Thanks for your work on this!

@WikiRik WikiRik merged commit 5f621d7 into sequelize:v6 Sep 22, 2022
@github-actions
Copy link
Contributor

🎉 This PR is included in version 6.23.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WikiRik WikiRik WikiRik approved these changes

@sdepold sdepold Awaiting requested review from sdepold

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nilabja-bhattacharya @sdepold @WikiRik @sudarshan12s