Remove the include option from Model.create

[ephys]

Feature Description

The include option in Model.create is counter-intuitive. I've seen many help requests (most recent: #14759) where the user expects include to select the association after the model has been created. In reality, it's used to create associated objects.

Currently, this only creates a player, not a team:

const createdPlayer = await Player.create(
  { name: "Player 1", team: { name: "My new team" } },
);

While this creates a player & a team and associates the team and the player

const createdPlayer = await Player.create(
  { name: "Player 1", team: { name: "My new team" } },
  { include: { association: 'team' } }
);

The thing is, Player already knows team is an association (associations & attributes cannot share the same name). The first example could already work, we don't need the second version.

I propose to remove the include option altogether.

Similarly, you should be able to do use the association field to link an association that already exists:

const team = await Team.create({ name: "My new team" });

const createdPlayer = await Player.create(
  { name: "Player 1", team },
);

Or that has been built but not persisted yet:

const team = Team.build({ name: "My new team" });

const createdPlayer = await Player.create(
  { name: "Player 1", team },
);

Is this feature dialect-specific?

• No. This feature is relevant to Sequelize as a whole.

Would you be willing to resolve this issue by submitting a Pull Request?

• Yes, I have the time and I know how to start.

---

Indicate your interest in the addition of this feature by adding the 👍 reaction. Comments such as "+1" will be removed.

[Pulkit0729]

Hi, I would like to work on the issue. Please specify if this is still open?

[ephys]

It is, we try to keep our issues up-to-date as much as possible

[Siddhant-Kashyap]

hello is it still open i would love to work on this

[WikiRik]

Yes, this is still open

[jacobmendoza]

Quickly checking if this is stuck. I see some pending changes were requested about a month ago in #16922 . Just in case I can assist in any way.

Very grateful for the work of everyone 🙏