Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect documentation on "Using Sequelize in AWS Lambda" #235

Open
fathergoose opened this issue Aug 10, 2022 · 2 comments
Open

Incorrect documentation on "Using Sequelize in AWS Lambda" #235

fathergoose opened this issue Aug 10, 2022 · 2 comments
Assignees

Comments

@fathergoose
Copy link

Hello sequelize maintainers, this is my first time contributing here. Forgive me if anything about this issue is off.

On Using Sequelize in AWS Lambda there are instructions for how one should manage a connection when in an AWS Lambda environment. On line 73 of the source there is a call sequelize.connectionManager.initPools().

From what I can tell, initPools was moved/removed with the release of 7.0.0-alpha15 when connectionManager was converted to typescript by @ephys.

I'm not sure if there is a new way to perform the function of initPools as described in the Lambda document, or if the feature was never supposed to be exposed in the first place. It doesn't seem to be part of the public API from what I can tell, at least not anymore.

I'm happy to make a PR to update the docs, or expose a new initPools method, but I don't know enough about the maintainers' intent or enough about the role of the previous initPools as used in the docs.

@WikiRik
Copy link
Member

WikiRik commented Aug 13, 2022

It seems to be part of the constructor now. Therefore it's not a part of the public API anymore, but I'm not so sure what to do in this case. I'll assign @ephys to this so she can look into this later.

@fathergoose
Copy link
Author

Hi y'all. My team is still stuck with alpha 13 without additional guidance because of the problem outlined above. I don't need much from the sequelize crew, I'm just looking to be pointed in the right direction.

I am happy to make a PR to either sequelize/sequelize and-or sequelize/website with a little bit of guidance. However, as of now, I'm not sure the function initPools was serving or the intention behind the refactor which removed it (is there documentation update to be made, or perhaps code to be added to serve in place of the former initPools method, or both?)

Admittedly, issues opened against the website repo may not be the best way of communicating with the sequelize team. I noticed a slack link on the website. I can meet there too for a more dynamic/real-time conversation.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants