Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Regarding Retry Functionality #167

Open
ksparakis opened this issue May 25, 2022 · 1 comment · May be fixed by #282
Open

Documentation Regarding Retry Functionality #167

ksparakis opened this issue May 25, 2022 · 1 comment · May be fixed by #282

Comments

@ksparakis
Copy link

Issue Creation Checklist

[X] I have read the contribution guidelines

Issue Description

I have been running through many github project issues and through a few google search results to try and understand how to enable Retry logic with sequelize and what its capabilities are and wether it works with transactions. This isn't officially documented anywhere and there is a lot of confusion around this without clear answers.

What was unclear/insufficient/not covered in the documentation

Everything around the retry option in sequelize is kind of a mystery.

  • Is something Like this still valid?
  • what are the limitations?
  • Does this retry transactions if they fail?
  • Does this retry individual queries?
retry: {
    match: [
        Sequelize.ConnectionError,
        Sequelize.ConnectionTimedOutError,
        Sequelize.TimeoutError,
        /Deadlock/i,
        'SQLITE_BUSY'],
    max: 3
}

If possible: Provide some suggestion on how we can enhance the docs

Would be nice to have a section on retry capabilities in the documentation, how it works and what are its limitations are.

Additional context

List of resources I was able to dig up regarding this question:

@ephys ephys transferred this issue from sequelize/sequelize May 25, 2022
@ephys
Copy link
Member

ephys commented May 25, 2022

Moved to the documentation website as it's where we keep issues related to the documentation.

I can already provide some info, the retry option is passed to this library: https://www.npmjs.com/package/retry-as-promised. I think we just pass them as-is, with default values.

@fzn0x fzn0x linked a pull request Oct 2, 2022 that will close this issue
@ephys ephys removed the type: docs label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants