Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Duration on libcore once it's stable #1123

Closed
clarfonthey opened this issue Dec 14, 2017 · 2 comments
Closed

Allow Duration on libcore once it's stable #1123

clarfonthey opened this issue Dec 14, 2017 · 2 comments
Labels
enhancement good first issue

Comments

@clarfonthey
Copy link
Contributor

clarfonthey commented Dec 14, 2017 •
edited

There's currently an accepted issue (rust-lang/rust#46520) to move the std::time::Duration type to core::time::Duration. Once this is stable, there should be a change to serde/src/lib.rs to change the import of Duration so that it's allowed on no_std builds.
@dtolnay
Copy link
Member

dtolnay commented Dec 14, 2017

Tagging breaking change because this would involve raising the minimum supported Rust version.

@dtolnay
Copy link
Member

dtolnay commented May 20, 2018

No longer a breaking change because we have added a Serde build.rs script that can do version detection and conditionally enable the Duration impl on sufficiently new compilers.

@dtolnay dtolnay mentioned this issue Jun 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dtolnay @clarfonthey