Support #[derive(Serialize, Deserialize)] when using associated types #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtolnay
reviewed
Apr 11, 2018
serde_derive/src/bound.rs
Outdated
| .flat_map(|field| { | ||
| let field_ty = field.ty; | ||
| let field_bound: Option<syn::WherePredicate> = match (field_ty, gen_bound_where(&field.attrs)) { | ||
| (&syn::Type::Path(ref ty_path), true) => match (ty_path.path.segments.first(), generics.params.first()) { |
There was a problem hiding this comment.
Please make this work even if the associated type is not from the first generic parameter.
#[derive(Serialize, Deserialize)]
struct AssocDerive<S, T: AssocSerde> {
s: S,
assoc: T::Assoc,
}
dtolnay
reviewed
Apr 11, 2018
serde_derive/src/bound.rs
Outdated
| ) -> syn::Generics | ||
| where | ||
| F: Fn(&attr::Field) -> Option<&[syn::WherePredicate]>, | ||
| W: for<'a> Fn(&attr::Field) -> bool, |
There was a problem hiding this comment.
The 'a lifetime parameter is never used.
|
Thanks btw! This is going to fix a quite common stumbling block. |
Also, removes extraneous `where for`
|
Those errors should be fixed now. |
Osspial
force-pushed
the
assoc_type_derive
branch
from
87b97fb
to
629bf7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, structs and enums that had fields using associated types wouldn't have the appropriate where bounds set. This fixes that, meaning that this now builds:
Fixes #1208.