Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Serialize and Deserialize for RangeInclusive #1347

Merged
merged 2 commits into from Aug 7, 2018
Merged

Implement Serialize and Deserialize for RangeInclusive #1347

merged 2 commits into from Aug 7, 2018

Conversation

c410-f3r
Copy link
Contributor

@c410-f3r c410-f3r commented Aug 5, 2018 •
edited

Copied implementation from Range, is it OK?

Edit: I will fix the failing tests but RangeInclusive structure was modified in #51622, should we wait for the next Rust release?

dtolnay
dtolnay reviewed Aug 5, 2018
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you check why the build is failing?

@c410-f3r
Copy link
Contributor Author

c410-f3r commented Aug 5, 2018

@dtolnay Tests are fixed. Not sure about the additional field since every new instance of RangeInclusive starts with the same value is_empty: None.

dtolnay
dtolnay approved these changes Aug 7, 2018
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit 5fff0d9 into serde-rs:master Aug 7, 2018
@dtolnay
Copy link
Member

dtolnay commented Aug 7, 2018

I published these impls in serde 1.0.71.

@c410-f3r
Copy link
Contributor Author

c410-f3r commented Aug 7, 2018

Thanks! :)

@dtolnay dtolnay mentioned this pull request Feb 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@c410-f3r @dtolnay