Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for NonZeroI* types #1589

Merged
merged 2 commits into from Jul 28, 2019
Merged

Add support for NonZeroI* types #1589

merged 2 commits into from Jul 28, 2019

Conversation

Flaise
Copy link
Contributor

@Flaise Flaise commented Jul 28, 2019

Resolves issue #1574 - now that NonZeroI* types are stabilized, it's helpful to support them.

dtolnay
dtolnay reviewed Jul 28, 2019
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This fails to build on rustc 1.28 - 1.33 though. The new impls will need to be under a different gate in build.rs.

@Flaise
Copy link
Contributor Author

Flaise commented Jul 28, 2019

Is that better? 1.27 and 1.28 still don't work but that appears unrelated to this PR.

dtolnay
dtolnay approved these changes Jul 28, 2019
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit ce75418 into serde-rs:master Jul 28, 2019
@dtolnay
Copy link
Member

dtolnay commented Jul 28, 2019

Released in 1.0.98.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Flaise @dtolnay