Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Range{From,To} deserialize mixup #2653

Merged
merged 1 commit into from Nov 21, 2023
Merged

Fix Range{From,To} deserialize mixup #2653

merged 1 commit into from Nov 21, 2023
+36 −36

Conversation

emilbonnek
Copy link
Contributor

@emilbonnek emilbonnek commented Nov 21, 2023 •
edited

closes #2652

Issue TL;DR
RangeFrom and RangeTo implementations seems to have been switched around and RangeFrom was expecting a 'end' field when it should be expecting a 'start' field.

dtolnay
dtolnay approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Good catch.

@dtolnay dtolnay merged commit 24a78f0 into serde-rs:master Nov 21, 2023
15 checks passed
@dtolnay dtolnay mentioned this pull request Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deserialization for RangeFrom and RangeTo doesn't work
2 participants
@emilbonnek @dtolnay