Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems releasing v6.2.1 #1584

Closed
reconbot opened this issue Jun 28, 2018 · 11 comments
Closed

Problems releasing v6.2.1 #1584

reconbot opened this issue Jun 28, 2018 · 11 comments

Comments

@reconbot
Copy link
Member

  • SerialPort Version: v6.2.1

I'm getting hit by this bug on master prebuild/prebuildify#10 and then in my v6.3.2 tag I've changed to building on node 10 and I'm getting hit by this bug prebuild/prebuild#221

I think I need to go back to node 8 for builds and then set build_v8_with_gn=false in the configure script run by prebuild but I have no idea how to do that.

The issue with building for node10 when running node 8 is easily reproducible locally by running npm run prebuild. I have to come back to this as I've spent more on this issue than I should.

I haven't npm released v6.2.1 because I keep changing some of the code behind it for build purposes. I would love to get it out.
@ralphtheninja
Copy link

@reconbot Let me know how I can help.

@reconbot
Copy link
Member Author

reconbot commented Jun 29, 2018 via email

@ralphtheninja
Copy link

ralphtheninja commented Jun 29, 2018 •
edited

Are you using prebuildify or prebuild?

then in my v6.3.2 tag

I guess you meant 6.2.1 here?

@reconbot
Copy link
Member Author

reconbot commented Jun 29, 2018 via email

@ralphtheninja
Copy link

ralphtheninja commented Jun 29, 2018 •
edited

Prebuild (see our package.json) but it's a similar issue.

Aye, noticed prebuild in package.json. Was just a bit confused when you mentioned prebuildify.

Anyway, I personally don't have these problems when building locally by doing e.g. npm run prebuild on latest master. Meaning I'm running node v10.5.0 and npm run rebuild builds all binaries. I'm on linux though and installing node via nvm (not sure that matters, but just explaining my environment).

$ l prebuilds/
total 360K
drwxr-xr-x  2 lms lms 4.0K Jun 29 12:19 .
drwxr-xr-x 13 lms lms 4.0K Jun 29 12:19 ..
-rw-r--r--  1 lms lms  21K Jun 29 12:19 serialport-v6.2.0-electron-v47-linux-x64.tar.gz
-rw-r--r--  1 lms lms  21K Jun 29 12:19 serialport-v6.2.0-electron-v48-linux-x64.tar.gz
-rw-r--r--  1 lms lms  21K Jun 29 12:19 serialport-v6.2.0-electron-v49-linux-x64.tar.gz
-rw-r--r--  1 lms lms  21K Jun 29 12:19 serialport-v6.2.0-electron-v50-linux-x64.tar.gz
-rw-r--r--  1 lms lms  21K Jun 29 12:19 serialport-v6.2.0-electron-v51-linux-x64.tar.gz
-rw-r--r--  1 lms lms  21K Jun 29 12:19 serialport-v6.2.0-electron-v53-linux-x64.tar.gz
-rw-r--r--  1 lms lms  21K Jun 29 12:19 serialport-v6.2.0-electron-v54-linux-x64.tar.gz
-rw-r--r--  1 lms lms  21K Jun 29 12:19 serialport-v6.2.0-electron-v57-linux-x64.tar.gz
-rw-r--r--  1 lms lms  20K Jun 29 12:19 serialport-v6.2.0-node-v46-linux-x64.tar.gz
-rw-r--r--  1 lms lms  20K Jun 29 12:19 serialport-v6.2.0-node-v47-linux-x64.tar.gz
-rw-r--r--  1 lms lms  21K Jun 29 12:19 serialport-v6.2.0-node-v48-linux-x64.tar.gz
-rw-r--r--  1 lms lms  21K Jun 29 12:19 serialport-v6.2.0-node-v51-linux-x64.tar.gz
-rw-r--r--  1 lms lms  21K Jun 29 12:19 serialport-v6.2.0-node-v57-linux-x64.tar.gz
-rw-r--r--  1 lms lms  21K Jun 29 12:19 serialport-v6.2.0-node-v59-linux-x64.tar.gz
-rw-r--r--  1 lms lms  21K Jun 29 12:19 serialport-v6.2.0-node-v64-linux-x64.tar.gz

@ralphtheninja
Copy link

ralphtheninja commented Jun 29, 2018 •
edited

Aaah my bad, I probably misunderstood again. So building all binaries fails for node < 10. But if you instead switch to node 10 you get other problems with uploading to github. Does that summarize it correctly?

@ralphtheninja
Copy link

@reconbot Another alternative is to use prebuild-ci and move away from the BINARY_BUILDER thing. We have used it in leveldown for quite some time now and it works really well. Let me know if you need me to walk you through it.

@reconbot
Copy link
Member Author

reconbot commented Jun 29, 2018 via email

@reconbot
Copy link
Member Author

Looks like prebuild-ci will upload whatever version is running when the command is invoked (eg, that version of the os and node)?

@reconbot
Copy link
Member Author

I dislike that prebuild --all is broken when it builds for node 10 from node 8, but I guess this works too. 🤷‍♀️

I've updated the configs to support prebuild-ci's new setup and successfully released v6.2.1 🎉

Thanks for the tip!

@ralphtheninja
Copy link

I dislike that prebuild --all is broken when it builds for node 10 from node 8, but I guess this works too. woman_shrugging

I also dislike this, but difficult to do something easy about it imo.

Looks like prebuild-ci will upload whatever version is running when the command is invoked (eg, that version of the os and node)?

That's correct!

@lock lock bot locked as resolved and limited conversation to collaborators Dec 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reconbot @ralphtheninja