Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client-side-navigation struggles with special characters (%, ?) #312

Closed
Entkenntnis opened this issue Jun 15, 2020 · 5 comments · Fixed by #361
Closed

client-side-navigation struggles with special characters (%, ?) #312

Entkenntnis opened this issue Jun 15, 2020 · 5 comments · Fixed by #361
Labels
bug Something isn't working
Milestone

Comments

@Entkenntnis
Copy link
Member

Entkenntnis commented Jun 15, 2020

https://de.serlo.org/mathe/funktionen/wichtige-funktionstypen-eigenschaften

grafik

'%' is breaking client-side-navigation

Also page 2 and 3 of this course: https://de.serlo.org/43180/uebersicht

Will have to lookup how next router expect the url to be (decoded or not, etc...) and change it to it.

@Entkenntnis Entkenntnis added the bug Something isn't working label Jun 15, 2020
@inyono
Copy link
Member

inyono commented Jun 15, 2020

ping #292

@Entkenntnis Entkenntnis changed the title mathjax in alias client-side-navigation struggles with special characters (%, ?) Jun 22, 2020
@Entkenntnis Entkenntnis added this to the 100% FRONTEND milestone Jun 22, 2020
@elbotho
Copy link
Member

elbotho commented Jun 29, 2020

Puh, this might go way upstream. Next.js Bug, related PR that might fix it and a node bug.

@inyono
Copy link
Member

inyono commented Jun 30, 2020

Okay, how do we approach this? Is there an easy way for us to disable client-side navigation for urls containing those characters?

@elbotho
Copy link
Member

elbotho commented Jun 30, 2020

Maybe @Entkenntnis could take a look if we can fix it on our end somehow.
But then yes: Not using CSR for those urls is easy,
we might even fall back to the id for those urls and still use CSR <- I guess that's my preferred solution

@sentry-io
Copy link

sentry-io bot commented Jul 2, 2020

Sentry issue: FRONTEND-2A

(contains urls that have a link to a site that doesn't work during CSR)

@Entkenntnis Entkenntnis moved this from next up: decided, ready to start to review / feedback in P Responsive Redesign Jul 2, 2020
@Entkenntnis Entkenntnis moved this from review / feedback to staging in P Responsive Redesign Jul 6, 2020
P Responsive Redesign automation moved this from staging to Done Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
P Responsive Redesign
  
Done (merged into staging)
3 participants