Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some git dependencies for yarn packages aren't handled correctly #74

Open
rvem opened this issue May 25, 2023 · 0 comments
Open

Some git dependencies for yarn packages aren't handled correctly #74

rvem opened this issue May 25, 2023 · 0 comments

Comments

@rvem
Copy link
Member

rvem commented May 25, 2023

Git dependency for the yarn package provided using the following way won't be handled properly

  "dependencies": {
    "is-odd": "https://github.com/i-voted-for-trump/is-odd",
  }

It'll have the corresponding entry in `yarn.lock:

"is-odd@https://github.com/i-voted-for-trump/is-odd":
  version "3.0.1"
  resolved "https://github.com/i-voted-for-trump/is-odd#a80ee0d831a8ee69f1fad5b4673491847975eb26"
  dependencies:
    is-number "^6.0.0"

And the resolved will be parsed as it was a file that should be downloaded from https://github.com/i-voted-for-trump/is-odd and the expected hash is a80ee0d831a8ee69f1fad5b4673491847975eb26, while in fact, this is a reference to a git repository and the revision is specified after the #

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant