Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[/Resources/TOPIC_NAME/DependsOn/0] 'null' values are not allowed in templates #177

Open
lkolchin opened this issue Oct 11, 2019 · 0 comments

Comments

@lkolchin
Copy link

lkolchin commented Oct 11, 2019

Here is what I've got in the serverless.yaml

      # Dist list subscription for prod alerts
      AlertTopicSubscription:
        Type: AWS::SNS::Subscription
        Condition: CreateResourcesProdStage
        Properties:
          Endpoint: ${self:custom.alarms_emails.prod_dist_list1}
          Protocol: email
          TopicArn: ${self:provider.AlertTopic}

Getting an error during deployment even if condition is false:

Serverless Error ---------------------------------------

[/Resources/AlertTopicSubscription/DependsOn/0] 'null' values are not allowed in templates

Because -
Plugin generated this Erroneous resource in compiled-cloudformation-template-alias.json:

  AlertTopicSubscription:
    Type: AWS::SNS::Subscription
    Condition: CreateResourcesProdStage
    Properties:
      Endpoint: {}
      Protocol: email
      TopicArn: arn:aws:sns:ap-southeast-2:2222222222:market-base-infra-topics-sandbox-alerts
    DependsOn:
      - null
      - null

Bug to fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant