Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: User defined tsconfig paths #205

Merged
merged 2 commits into from Sep 23, 2021
Merged

feat: User defined tsconfig paths #205

merged 2 commits into from Sep 23, 2021

Conversation

Scotsoo
Copy link
Contributor

@Scotsoo Scotsoo commented May 1, 2020

Implements #179

Provide a small snippet to the serverless.yaml file:

custom:
  serverlessPluginTypescript:
    tsConfigFileLocation: './tsconfig.build.json'

To define where the relevant tsConfig file lies.

@Scotsoo Scotsoo changed the title User defined tsconfig paths feat: User defined tsconfig paths May 1, 2020
@Scotsoo Scotsoo mentioned this pull request May 1, 2020
Open
speedazerty
speedazerty reviewed May 1, 2020
View reviewed changes
Copy link

@speedazerty speedazerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work ! Yeah ! Please merge this PR !

@Scotsoo
Copy link
Contributor Author

Scotsoo commented May 4, 2020

@JackCuthbert @divyenduz @timsuchanek @schickling Are you guys planning on maintaining this repo?

@KingDarBoja
Copy link

@Scotsoo you can use either my fork which got today the custom path to tsconfig feature (Thanks to JeremiGendron) or this new fork from JeremiGendron which seems to be better organized.

@Scotsoo
Copy link
Contributor Author

Scotsoo commented Sep 23, 2021

@medikoo Any chance of getting this merged in at all? I see you're the only active maintainer of this repo currently!

medikoo
medikoo approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Scotsoo 👍

@medikoo medikoo merged commit a367dcd into serverless:master Sep 23, 2021
@medikoo
Copy link
Contributor

medikoo commented Sep 23, 2021

Published with v2.1.0

@Scotsoo
Copy link
Contributor Author

Scotsoo commented Sep 23, 2021

Thank you @medikoo !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@speedazerty speedazerty speedazerty left review comments

@medikoo medikoo medikoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Scotsoo @KingDarBoja @medikoo @speedazerty