Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Remove missing CLI options schema deprecation #10001

Merged
merged 1 commit into from Sep 24, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Sep 24, 2021

Instead, signal lack of schema with a warning

Instead signal inconsistency with a warning
@medikoo medikoo added cat/plugin deprecation Deprecation proposal (breaking with next major) cat/cli labels Sep 24, 2021
@medikoo medikoo self-assigned this Sep 24, 2021
@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #10001 (911dc8c) into master (2ef5b39) will decrease coverage by 0.10%.
The diff coverage is 66.66%.

❗ Current head 911dc8c differs from pull request most recent head 8f58a59. Consider uploading reports for the commit 8f58a59 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10001      +/-   ##
==========================================
- Coverage   86.28%   86.17%   -0.11%     
==========================================
  Files         330      330              
  Lines       13159    13169      +10     
==========================================
- Hits        11354    11349       -5     
- Misses       1805     1820      +15     
Impacted Files Coverage Δ
lib/cli/commands-schema/resolve-final.js 91.07% <66.66%> (ø)
lib/plugins/aws/deployList.js 71.42% <66.66%> (-20.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ef5b39...8f58a59. Read the comment docs.

@medikoo medikoo merged commit 5b38232 into master Sep 24, 2021
@medikoo medikoo deleted the 0924-revert-from-options-schema-validation branch September 24, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/cli cat/plugin deprecation Deprecation proposal (breaking with next major)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant