Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Revert from unconditional .env support #10003

Merged
merged 1 commit into from Sep 24, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Sep 24, 2021

Internally we decided to not pursue .env loading unconditionally as we were worried to break for users which already use .env files to configure the environment for lambdas, where the same root folder is shared by both service configuration and lambda logic.

This PR is purely about removing the deprecation with which such move was announced

Closes: #8566

@medikoo medikoo added deprecation Deprecation proposal (breaking with next major) cat/cli labels Sep 24, 2021
@medikoo medikoo self-assigned this Sep 24, 2021
@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #10003 (9cd7eee) into master (ffbdfed) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10003      +/-   ##
==========================================
- Coverage   86.17%   86.17%   -0.01%     
==========================================
  Files         330      330              
  Lines       13169    13161       -8     
==========================================
- Hits        11349    11342       -7     
+ Misses       1820     1819       -1     
Impacted Files Coverage Δ
lib/cli/conditionally-load-dotenv.js 100.00% <ø> (+6.66%) ⬆️
lib/cli/commands-schema/resolve-final.js 91.07% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffbdfed...9cd7eee. Read the comment docs.

@medikoo medikoo merged commit 40cdb4f into master Sep 24, 2021
@medikoo medikoo deleted the 0924-revert-dotenv-deprecation branch September 24, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/cli deprecation Deprecation proposal (breaking with next major)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AJV Schema should accept useDotenv=false
1 participant