Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone: Fix npm command handling issue #10014

Merged
merged 3 commits into from Sep 28, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Sep 28, 2021

Issue observed in CI fails, after refactoring plugin install command.

It appeared npm commands were not configured correctly for spawn in the context of standalone installations.

Additionally upgraded to rely on npm that recognizes node.js v14 (as standalone build now is based on Node.js v14)

@medikoo medikoo self-assigned this Sep 28, 2021
@medikoo medikoo changed the title Debug: Plugin install issue Debug: CI plugin install issue Sep 28, 2021
@medikoo medikoo force-pushed the 0928-debug-plugin-install-issue branch 4 times, most recently from 98849d6 to 8bd0371 Compare September 28, 2021 08:02
@medikoo medikoo changed the title Debug: CI plugin install issue Standalone: Fix npm command handling issue Sep 28, 2021
@medikoo medikoo marked this pull request as ready for review September 28, 2021 08:02
@medikoo medikoo force-pushed the 0928-debug-plugin-install-issue branch from 8bd0371 to cb3b0db Compare September 28, 2021 08:10
@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #10014 (cb3b0db) into master (cd9b823) will not change coverage.
The diff coverage is 77.77%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10014   +/-   ##
=======================================
  Coverage   86.03%   86.03%           
=======================================
  Files         332      332           
  Lines       13248    13248           
=======================================
  Hits        11398    11398           
  Misses       1850     1850           
Impacted Files Coverage Δ
scripts/pkg/build.js 0.00% <0.00%> (ø)
commands/plugin-install.js 63.23% <66.66%> (ø)
lib/cli/interactive-setup/service.js 100.00% <100.00%> (ø)
lib/plugins/plugin/install.js 94.31% <100.00%> (ø)
lib/utils/npm-command-deferred.js 75.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd9b823...cb3b0db. Read the comment docs.

@medikoo medikoo merged commit 6f88c11 into master Sep 28, 2021
@medikoo medikoo deleted the 0928-debug-plugin-install-issue branch September 28, 2021 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant