Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Plugins): Seclude plugin uninstall standalone command #10015

Merged

Conversation

issea1015
Copy link
Contributor

Closes: #9740

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #10015 (782ebcb) into master (6f88c11) will decrease coverage by 0.09%.
The diff coverage is 66.66%.

❗ Current head 782ebcb differs from pull request most recent head 256c942. Consider uploading reports for the commit 256c942 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10015      +/-   ##
==========================================
- Coverage   86.03%   85.93%   -0.10%     
==========================================
  Files         332      333       +1     
  Lines       13248    13305      +57     
==========================================
+ Hits        11398    11434      +36     
- Misses       1850     1871      +21     
Impacted Files Coverage Δ
lib/plugins/plugin/uninstall.js 94.28% <ø> (ø)
commands/plugin-uninstall.js 64.40% <64.40%> (ø)
commands/plugin-install.js 62.12% <100.00%> (-1.12%) ⬇️
scripts/serverless.js 56.07% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f88c11...256c942. Read the comment docs.

@issea1015
Copy link
Contributor Author

issea1015 commented Sep 28, 2021

@medikoo Let me make a quick fix on the test -> done

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @issea1015. It looks very good! I have just a few minor suggestions.

commands/plugin-uninstall.js Outdated Show resolved Hide resolved
commands/plugin-uninstall.js Outdated Show resolved Hide resolved
commands/plugin-uninstall.js Outdated Show resolved Hide resolved
@issea1015
Copy link
Contributor Author

@medikoo 👍 Done

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @issea1015 ! Thank you

@medikoo medikoo merged commit 26ce1c6 into serverless:master Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: Seclude plugin install & plugin uninstall commands out of internals
2 participants