Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CLI): Handle gently case where temp folder is on other device #10124

Merged
merged 1 commit into from Oct 20, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Oct 20, 2021

Fixes: #10123

@medikoo medikoo self-assigned this Oct 20, 2021
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #10124 (0d957de) into master (3e19547) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 0d957de differs from pull request most recent head 0ec36a8. Consider uploading reports for the commit 0ec36a8 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10124   +/-   ##
=======================================
  Coverage   85.35%   85.35%           
=======================================
  Files         337      337           
  Lines       13721    13722    +1     
=======================================
+ Hits        11711    11712    +1     
  Misses       2010     2010           
Impacted Files Coverage Δ
lib/utils/logDeprecation.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e19547...0ec36a8. Read the comment docs.

@medikoo medikoo requested a review from pgrzesik October 20, 2021 14:07
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch 👍

@medikoo medikoo merged commit a030636 into master Oct 20, 2021
@medikoo medikoo deleted the 1020-fix-cross-dev-slsdoctor branch October 20, 2021 14:15
@cbrianhill
Copy link

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sls doctor breaks if os.tmpdir() and os.homedir() are on different filesystems
3 participants