Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Lambda): Add CF function support to reservedConcurrency #10129

Merged
merged 1 commit into from Oct 21, 2021
Merged

feat(Lambda): Add CF function support to reservedConcurrency #10129

merged 1 commit into from Oct 21, 2021

Conversation

ROSeaboyer
Copy link
Contributor

I didn't create an explicit issue for this, but this is something I'm running into and figured the same approach I used for my last PR would suffice. If you want an issue explicitly created for this, let me know.

This just fixes another validation issue where serverless configuration validation isn't accepting native CF functions, so I've fixed this as well.

@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #10129 (7c22d2d) into master (204f205) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10129   +/-   ##
=======================================
  Coverage   85.35%   85.35%           
=======================================
  Files         337      337           
  Lines       13722    13723    +1     
=======================================
+ Hits        11712    11713    +1     
  Misses       2010     2010           
Impacted Files Coverage Δ
lib/plugins/aws/provider.js 94.29% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 204f205...7c22d2d. Read the comment docs.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ROSeaboyer ! Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants