Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deployment bucket versioning #10137

Merged
merged 1 commit into from Oct 25, 2021
Merged

Fix deployment bucket versioning #10137

merged 1 commit into from Oct 25, 2021

Conversation

mars-lan
Copy link
Contributor

@mars-lan mars-lan commented Oct 22, 2021

Closes: #10130

Changes in README.md is a result of running yarn prettify.

@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #10137 (140338a) into master (b7a6349) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10137   +/-   ##
=======================================
  Coverage   85.35%   85.35%           
=======================================
  Files         337      337           
  Lines       13725    13725           
=======================================
  Hits        11715    11715           
  Misses       2010     2010           
Impacted Files Coverage Δ
...ib/plugins/aws/package/lib/generateCoreTemplate.js 95.45% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7a6349...140338a. Read the comment docs.

@mars-lan
Copy link
Contributor Author

@medikoo

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mars-lan, nice find!

@medikoo medikoo merged commit 39bdea0 into serverless:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable deployment bucket versioning breaks encryption & public access block
2 participants