Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Expose dashboard provider name in deploy tagline log #10194

Merged
merged 1 commit into from Nov 10, 2021

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Nov 4, 2021

Follows internal agreements

Accompanied by serverless/dashboard-plugin#639

@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #10194 (5e4102c) into master (6a2be57) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10194   +/-   ##
=======================================
  Coverage   85.35%   85.36%           
=======================================
  Files         339      339           
  Lines       13831    13833    +2     
=======================================
+ Hits        11806    11808    +2     
  Misses       2025     2025           
Impacted Files Coverage Δ
lib/plugins/aws/deploy/index.js 98.71% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a2be57...5e4102c. Read the comment docs.

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@medikoo medikoo merged commit 6698fa6 into master Nov 10, 2021
@medikoo medikoo deleted the 1104-add-dashbaord-provider-name-to-deploy-info branch November 10, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants